DEV-7187: Validate exemption cert covers destination state#22
Open
DEV-7187: Validate exemption cert covers destination state#22
Conversation
…ore applying Single-state exemption certificates were being applied to all orders regardless of shipping destination, because the cert ID was passed to TaxCloud's Lookup unconditionally. Now we call GetExemptCertificates to check the cert's exempt states against the destination state, with 1-hour caching. Fails closed (no exemption) if the SOAP call errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetExemptCertificatesto retrieve the cert's exempt states and verify the destination state is coveredRoot cause
The plugin stored a single
taxcloud_certUUID per customer and passed it on everyLookupcall. The TaxCloud API'sspTransactionLookuptreats any non-null cert ID as a binary "zero out all tax" switch without checkingExemptionCertificateStates. This is an API-level bug too, but this PR adds a client-side guard in the Magento plugin.Changes
Model/Api.php: AddedgetValidatedCertificateID()andextractExemptStatesFromResponse(). UpdatedlookupTaxes()call site to validate before sending.Test/Unit/Model/ApiTest.php: 10 parameterized + standalone test cases covering: state match/no-match via SOAP, state match/no-match via cache, SOAP failure (fail closed), no cert on customer, single-object SOAP response edge case.🤖 Generated with Claude Code